Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

receiver: Test data extraction of responses #2698

Merged
merged 2 commits into from
Jan 1, 2025
Merged

receiver: Test data extraction of responses #2698

merged 2 commits into from
Jan 1, 2025

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented Dec 1, 2024

Related #2273

@pfps
Copy link
Collaborator

pfps commented Dec 1, 2024

There are a bunch of PRs queued up. Which should be checked out first, although I will not be able to check things out until about 20 December.

@MattHag
Copy link
Collaborator Author

MattHag commented Dec 1, 2024 •
edited
Loading

Yes, the settings one is the biggest, which should come first.

Then I'll merge all of them into my fork and rebase each on top to have a functional code base with the latest state.

@pfps
Copy link
Collaborator

pfps commented Dec 1, 2024

You mean the one that add back and forward?

@MattHag
Copy link
Collaborator Author

MattHag commented Dec 1, 2024

No, this one is a huge one, which resolves quite much
#2660

@MattHag MattHag force-pushed the test_receiver_response branch from 8c67fbd to d7a353c Compare December 1, 2024 21:31
@MattHag MattHag changed the title receiver: Test extraction of serial and max. number of devices receiver: Test data extraction of responses Dec 1, 2024
@pfps
Copy link
Collaborator

pfps commented Jan 1, 2025

There are conflicts to be resolved here.

@MattHag MattHag force-pushed the test_receiver_response branch from d7a353c to a717aee Compare January 1, 2025 17:06
@MattHag MattHag force-pushed the test_receiver_response branch from a717aee to 0cd108c Compare January 1, 2025 17:08
@MattHag MattHag requested a review from pfps January 1, 2025 17:10
@MattHag
Copy link
Collaborator Author

MattHag commented Jan 1, 2025

Fixed

pfps
pfps approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@pfps pfps merged commit f28a923 into pwr-Solaar:master Jan 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfps pfps pfps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattHag @pfps